linux-kernel - [REGRESSION][BISECTED] flood of "hid-generic ... control queue full" since v5.14-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210816130059.3yxtdvu2r7wo4uu3@lion.mk-sys.cz>
Date:   Mon, 16 Aug 2021 15:00:59 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     linux-usb@...r.kernel.org, Alan Stern <stern@...land.harvard.edu>,
        linux-input@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>
Subject: [REGRESSION][BISECTED] flood of "hid-generic ... control queue full"
 since v5.14-rc1

Hello,

starting with v5.14-rc1, my kernel log gets flooded with messages

  hid-generic 0003:051D:0002.0002: control queue full

at rate of ~33 per second. Device 051d:0002 is an APC UPS (BR-650 VA).
I bisected the issue to commit

  7652dd2c5cb7 ("USB: core: Check buffer length matches wLength for control transfers")

Reverting this commit on top of v5.14-rc6 resolves the issue. I suspect
the problem is some missing cleanup when usb_submit_urb() bails out on
the newly added check but I'm not familiar enough with the code to see
what is missing or if the problem is on USB or HID side.

Michal

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)