linux-kernel - Re: [PATCH v14 088/138] mm/filemap: Add filemap_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YRnVXaZDNuBnyLA4@casper.infradead.org>
Date:   Mon, 16 Aug 2021 04:02:53 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     David Howells <dhowells@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v14 088/138] mm/filemap: Add filemap_get_folio

On Tue, Aug 10, 2021 at 11:05:33PM +0100, David Howells wrote:
> Matthew Wilcox (Oracle) <willy@...radead.org> wrote:
> 
> > filemap_get_folio() is a replacement for find_get_page().
> > Turn pagecache_get_page() into a wrapper around __filemap_get_folio().
> > Remove find_lock_head() as this use case is now covered by
> > filemap_get_folio().
> > 
> > Reduces overall kernel size by 209 bytes.  __filemap_get_folio() is
> > 316 bytes shorter than pagecache_get_page() was, but the new
> > pagecache_get_page() is 99 bytes
> 
> longer, one presumes.

In total -- the old pagecache_get_page() turns into
__filemap_get_folio(), but the wrapper is 99 bytes in size.

Added the word "wrapper" to make this clearer.