linux-kernel - Re: [PATCH v6 3/5] iio: adc: ad7949: add vref selection support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Aug 2021 09:07:52 -0400
From:   "Liam Beguin" <liambeguin@...il.com>
To:     "Andy Shevchenko" <andy.shevchenko@...il.com>
Cc:     "Lars-Peter Clausen" <lars@...afoo.de>,
        "Michael Hennerich" <Michael.Hennerich@...log.com>,
        "Jonathan Cameron" <jic23@...nel.org>,
        "Charles-Antoine Couret" <charles-antoine.couret@...ensium.com>,
        Nuno Sá <Nuno.Sa@...log.com>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        "linux-iio" <linux-iio@...r.kernel.org>,
        "devicetree" <devicetree@...r.kernel.org>,
        "Rob Herring" <robh+dt@...nel.org>
Subject: Re: [PATCH v6 3/5] iio: adc: ad7949: add vref selection support

On Mon Aug 16, 2021 at 8:48 AM EDT, Andy Shevchenko wrote:
> On Mon, Aug 16, 2021 at 3:39 PM Liam Beguin <liambeguin@...il.com>
> wrote:
> > On Mon Aug 16, 2021 at 4:04 AM EDT, Andy Shevchenko wrote:
> > > On Mon, Aug 16, 2021 at 12:35 AM Liam Beguin <liambeguin@...il.com>
> > > wrote:
>
> ...
>
> > > > +       tmp = 4096000;
> > > > +       ret = device_property_read_u32(dev, "adi,internal-ref-microvolt", &tmp);
> > >
> > > > +       if (ret < 0 && ret != -EINVAL) {
> >
> > Hi Andy,
> >
> > >
> > > What does this check (second part) is supposed to mean?
> > > The first part will make it mandatory, is it the goal?
> > >
> >
> > device_property_read_u32() will return -EINVAL if the property isn't
> > found in the devicetree.
> >
> > This checks for errors when the property is defined while keeping it
> > optional.
>
> Don't assign and don't check the error code of the API. As simply as
> that.

I'm not against getting rid of it, but I was asked to check for these
errors in earlier revisions of the patch.

Liam

>
> > > > +               dev_err(dev, "invalid value for adi,internal-ref-microvolt\n");
> > > > +               return ret;
> > > > +       }
>
>
> --
> With Best Regards,
> Andy Shevchenko