linux-kernel - Re: [PATCH] tracepoint: Fix the comment style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2005434147.15227.1629122570891.JavaMail.zimbra@efficios.com>
Date:   Mon, 16 Aug 2021 10:02:50 -0400 (EDT)
From:   Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To:     zhaoxiao <zhaoxiao@...ontech.com>, rostedt <rostedt@...dmis.org>
Cc:     "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        "Joel Fernandes, Google" <joel@...lfernandes.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracepoint: Fix the comment style

----- On Aug 16, 2021, at 1:24 AM, zhaoxiao zhaoxiao@...ontech.com wrote:

> Fix function name in tracepoint.c kernel-doc comment
> to remove a warning found by clang_w1.
> 
> kernel/tracepoint.c:589: warning: expecting prototype for
> register_tracepoint_notifier(). Prototype was for
> register_tracepoint_module_notifier() instead
> kernel/tracepoint.c:613: warning: expecting prototype for
> unregister_tracepoint_notifier(). Prototype was for
> unregister_tracepoint_module_notifier() instead

Thanks!

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>

> 
> Signed-off-by: zhaoxiao <zhaoxiao@...ontech.com>
> ---
> kernel/tracepoint.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c
> index efd14c79fab4..64ea283f2f86 100644
> --- a/kernel/tracepoint.c
> +++ b/kernel/tracepoint.c
> @@ -577,7 +577,7 @@ bool trace_module_has_bad_taint(struct module *mod)
> static BLOCKING_NOTIFIER_HEAD(tracepoint_notify_list);
> 
> /**
> - * register_tracepoint_notifier - register tracepoint coming/going notifier
> + * register_tracepoint_module_notifier - register tracepoint coming/going
> notifier
>  * @nb: notifier block
>  *
>  * Notifiers registered with this function are called on module
> @@ -603,7 +603,7 @@ int register_tracepoint_module_notifier(struct
> notifier_block *nb)
> EXPORT_SYMBOL_GPL(register_tracepoint_module_notifier);
> 
> /**
> - * unregister_tracepoint_notifier - unregister tracepoint coming/going notifier
> + * unregister_tracepoint_module_notifier - unregister tracepoint coming/going
> notifier
>  * @nb: notifier block
>  *
>  * The notifier block callback should expect a "struct tp_module" data
> --
> 2.20.1

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com