linux-kernel - Re: [RFC PATCH 2/2] PCI: apple: Add driver for the Apple M1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 15 Aug 2021 23:20:30 -0400
From:   Alyssa Rosenzweig <alyssa@...enzweig.io>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Rob Herring <robh+dt@...nel.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Stan Skowronek <stan@...ellium.com>,
        Marc Zyngier <maz@...nel.org>,
        Mark Kettenis <kettenis@...nbsd.org>,
        Sven Peter <sven@...npeter.dev>,
        Hector Martin <marcan@...can.st>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 2/2] PCI: apple: Add driver for the Apple M1

Hi Andy,

Thanks for the review.

>      +       depends on GPIOLIB
> 
>     It doesn’t seem to provide a GPIO. 

I thought that was needed to consume GPIOs, but it looks like other
PCI drivers don't do it. Removed.

>      +       if (IS_ERR(port))
>      +               return -ENODEV;
>      +
>      +       reset = devm_gpiod_get_index(pcie->dev, "reset", i, 0);
> 
>    Use appropriate flag.
>     
> 
>      +       if (IS_ERR(reset))
>      +               return PTR_ERR(reset);
>      +
>      +       gpiod_direction_output(reset, 0);
> 
>    Ditto and remove this line.

Fixed in v2, thank you.

>      +       usleep_range(5000, 10000);
> 
>    Sleep of such length should be explained.

Removed in v2.

>      +
> 
>    Redundant blank line 

Presumably fixed in v2.

>      +       pcie->bitmap = devm_kcalloc(pcie->dev,
>      BITS_TO_LONGS(pcie->nvecs),
>      +                                   sizeof(long), GFP_KERNEL);
> 
>    devm_bitmap_zalloc()

Done in v2.

>      +static const struct of_device_id apple_pci_of_match[] = {
>      +       { .compatible = "apple,pcie", .data = &apple_m1_cfg_ecam_ops },
> 
>     
> 
>      +       { },
> 
>    No comma for termination entry 

Fixed in v2.

BR,

Alyssa