linux-kernel - Re: [PATCH v2 11/20] platform/x86: intel_turbo_max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bd5c2c0c7863375a0bd3c6894194f7ba70915e17.camel@intel.com>
Date:   Mon, 16 Aug 2021 14:51:33 +0000
From:   "Pandruvada, Srinivas" <srinivas.pandruvada@...el.com>
To:     "alex.hung@...onical.com" <alex.hung@...onical.com>,
        "hpa@...hat.com" <hpa@...hat.com>,
        "Ma, Maurice" <maurice.ma@...el.com>,
        "Joseph, Jithu" <jithu.joseph@...el.com>,
        "acelan.kao@...onical.com" <acelan.kao@...onical.com>,
        "mgross@...ux.intel.com" <mgross@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "hdegoede@...hat.com" <hdegoede@...hat.com>,
        "mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>,
        "Zha, Qipeng" <qipeng.zha@...el.com>,
        "Thomas, Sujith" <sujith.thomas@...el.com>,
        "david.e.box@...ux.intel.com" <david.e.box@...ux.intel.com>,
        "Dell.Client.Kernel@...l.com" <Dell.Client.Kernel@...l.com>,
        "irenic.rajneesh@...il.com" <irenic.rajneesh@...il.com>
CC:     "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH v2 11/20] platform/x86: intel_turbo_max_3: Move to intel
 sub-directory

On Mon, 2021-08-16 at 18:51 +0800, Kate Hsuan wrote:
> Move intel_turbo_max_3 to intel sub-directory to improve readability
> and rename it from intel_turbo_max_3.c to turbo_max_3.c
> 
> Signed-off-by: Kate Hsuan <hpa@...hat.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>

> ---
>  drivers/platform/x86/Kconfig                           | 10 ----------
>  drivers/platform/x86/Makefile                          |  2 +-
>  drivers/platform/x86/intel/Kconfig                     | 10 ++++++++++
>  drivers/platform/x86/intel/Makefile                    |  4 ++--
>  .../x86/{intel_turbo_max_3.c => intel/turbo_max_3.c}   |  0
>  5 files changed, 13 insertions(+), 13 deletions(-)
>  rename drivers/platform/x86/{intel_turbo_max_3.c =>
> intel/turbo_max_3.c} (100%)
> 
> diff --git a/drivers/platform/x86/Kconfig
> b/drivers/platform/x86/Kconfig
> index a9eb1f6e184f..666103c7f0de 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1111,16 +1111,6 @@ config INTEL_IMR
>  
>  source "drivers/platform/x86/intel_speed_select_if/Kconfig"
>  
> -config INTEL_TURBO_MAX_3
> -       bool "Intel Turbo Boost Max Technology 3.0 enumeration driver"
> -       depends on X86_64 && SCHED_MC_PRIO
> -       help
> -         This driver reads maximum performance ratio of each CPU and
> set up
> -         the scheduler priority metrics. In this way scheduler can
> prefer
> -         CPU with higher performance to schedule tasks.
> -         This driver is only required when the system is not using
> Hardware
> -         P-States (HWP). In HWP mode, priority can be read from ACPI
> tables.
> -
>  config INTEL_UNCORE_FREQ_CONTROL
>         tristate "Intel Uncore frequency control driver"
>         depends on X86_64
> diff --git a/drivers/platform/x86/Makefile
> b/drivers/platform/x86/Makefile
> index 0389fe12e7c0..fb39644db7f9 100644
> --- a/drivers/platform/x86/Makefile
> +++ b/drivers/platform/x86/Makefile
> @@ -123,7 +123,7 @@ obj-$(CONFIG_WIRELESS_HOTKEY)               +=
> wireless-hotkey.o
>  
>  
>  obj-$(CONFIG_INTEL_SPEED_SELECT_INTERFACE)     +=
> intel_speed_select_if/
> -obj-$(CONFIG_INTEL_TURBO_MAX_3)                        +=
> intel_turbo_max_3.o
> +
>  obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL)                += intel-
> uncore-frequency.o
>  
>  
> diff --git a/drivers/platform/x86/intel/Kconfig
> b/drivers/platform/x86/intel/Kconfig
> index 83f7dc3e9506..8070804fe916 100644
> --- a/drivers/platform/x86/intel/Kconfig
> +++ b/drivers/platform/x86/intel/Kconfig
> @@ -99,4 +99,14 @@ config INTEL_SMARTCONNECT
>           Connect enabled, and if so disables it.
>  
>  
> +config INTEL_TURBO_MAX_3
> +       bool "Intel Turbo Boost Max Technology 3.0 enumeration driver"
> +       depends on X86_64 && SCHED_MC_PRIO
> +       help
> +         This driver reads maximum performance ratio of each CPU and
> set up
> +         the scheduler priority metrics. In this way scheduler can
> prefer
> +         CPU with higher performance to schedule tasks.
> +         This driver is only required when the system is not using
> Hardware
> +         P-States (HWP). In HWP mode, priority can be read from ACPI
> tables.
> +
>  endif # X86_PLATFORM_DRIVERS_INTEL
> diff --git a/drivers/platform/x86/intel/Makefile
> b/drivers/platform/x86/intel/Makefile
> index da8fbe87bf03..cff65fa2b1aa 100644
> --- a/drivers/platform/x86/intel/Makefile
> +++ b/drivers/platform/x86/intel/Makefile
> @@ -33,5 +33,5 @@ intel-rst-
> y                                                   := rst.o
>  obj-$(CONFIG_INTEL_RST)                                += intel-rst.o
>  intel-smartconnect-y                           := smartconnect.o
>  obj-$(CONFIG_INTEL_SMARTCONNECT)               += intel-smartconnect.o
> -
> -
> +intel_turbo_max_3-y                                            :=
> turbo_max_3.o
> +obj-$(CONFIG_INTEL_TURBO_MAX_3)                        +=
> intel_turbo_max_3.o
> diff --git a/drivers/platform/x86/intel_turbo_max_3.c
> b/drivers/platform/x86/intel/turbo_max_3.c
> similarity index 100%
> rename from drivers/platform/x86/intel_turbo_max_3.c
> rename to drivers/platform/x86/intel/turbo_max_3.c