linux-kernel - Re: [PATCH] f2fs: Add missing inline to f2fs_sanity_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YRwGyzZn+vxRoXTO@google.com>
Date:   Tue, 17 Aug 2021 11:58:19 -0700
From:   Jaegeuk Kim <jaegeuk@...nel.org>
To:     Nathan Chancellor <nathan@...nel.org>
Cc:     Chao Yu <chao@...nel.org>, linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] f2fs: Add missing inline to f2fs_sanity_check_cluster()
 stub

On 08/16, Nathan Chancellor wrote:
> On 8/16/2021 5:33 PM, Jaegeuk Kim wrote:
> > Hi Nathan,
> > 
> > On 08/16, Nathan Chancellor wrote:
> > > Without this, there is a warning in nearly every fs/f2fs/ file when
> > > F2FS_FS_COMPRESSION is not set:
> > > 
> > > In file included from fs/f2fs/super.c:31:
> > > fs/f2fs/f2fs.h:4251:13: warning: unused function 'f2fs_sanity_check_cluster' [-Wunused-function]
> > > static bool f2fs_sanity_check_cluster(struct dnode_of_data *dn) { return false; }
> > >              ^
> > > 1 warning generated.
> > > 
> > > Fixes: 1495870233e7 ("f2fs: compress: do sanity check on cluster")
> > 
> > This has not been merged yet, so if you don't mind, can I integrate your fix in
> > the original patch?
> 
> Sure thing!

Thanks~ :)

> 
> Cheers,
> Nathan