linux-kernel - Re: [PATCH] i2c: sun6i-pw2i: Prefer strscpy over strlcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YRwPvKZm8i47xFXP@kunai>
Date:   Tue, 17 Aug 2021 21:36:28 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Len Baker <len.baker@....com>
Cc:     Maxime Ripard <mripard@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        linux-i2c@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: sun6i-pw2i: Prefer strscpy over strlcpy

On Tue, Aug 17, 2021 at 06:58:59PM +0200, Len Baker wrote:
> strlcpy() reads the entire source buffer first. This read may exceed the
> destination size limit. This is both inefficient and can lead to linear
> read overflows if a source string is not NUL-terminated. The safe
> replacement is strscpy().
> 
> This is a previous step in the path to remove the strlcpy() function
> entirely from the kernel [1].
> 
> [1] https://github.com/KSPP/linux/issues/89
> 
> Signed-off-by: Len Baker <len.baker@....com>

Applied to for-next, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)