linux-kernel - Re: [PATCH] dt-bindings: PCI: faraday,ftpci100: Fix 'contains' schema usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 17 Aug 2021 22:27:52 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        linux-pci <linux-pci@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: PCI: faraday,ftpci100: Fix 'contains' schema usage

On Tue, Aug 17, 2021 at 7:47 PM Rob Herring <robh@...nel.org> wrote:

> The 'contains' keyword applies to elements within an array, so
> using 'items' only makes sense if the elements of the array are another
> array which is not the case for 'compatible' properties.
>
> Looking at the driver, it seems the intent was the condition should be
> true when 'faraday,ftpci100' is present, so we can drop
> 'cortina,gemini-pci'.
>
> Fixes: 2720b991337d ("dt-bindings: PCI: ftpci100: convert faraday,ftpci100 to YAML")
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: linux-pci@...r.kernel.org
> Signed-off-by: Rob Herring <robh@...nel.org>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij