linux-kernel - Re: [PATCH] staging:iio:ade7854 surround complex defines in parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210817043038.GA9492@challenge-bot.com>
Date:   Mon, 16 Aug 2021 21:30:38 -0700
From:   daniel watson <ozzloy@...llenge-bot.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>, linux-iio@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging:iio:ade7854 surround complex defines in
 parentheses

If this is a false positive from checkpatch, I can submit it as an
example to the checkpatch maintainers.  Do you think I should?

On Sun, Aug 15, 2021 at 08:25:51AM +0200, Greg Kroah-Hartman wrote:
> On Sat, Aug 14, 2021 at 07:31:15PM -0700, daniel watson wrote:
> > Error found by checkpatch.pl
> 
> What error?

$ git checkout 36a21d5172 drivers/staging/iio/meter/ade7854.h # before
Updated 1 path from 638ccd1543654

$ ./scripts/checkpatch.pl --terse --types COMPLEX_MACRO \
drivers/staging/iio/meter/ade7854.h
drivers/staging/iio/meter/ade7854.h:142: ERROR: Macros with complex
values should be enclosed in parentheses
drivers/staging/iio/meter/ade7854.h:143: ERROR: Macros with complex
values should be enclosed in parentheses
drivers/staging/iio/meter/ade7854.h:144: ERROR: Macros with complex
values should be enclosed in parentheses
total: 3 errors, 0 warnings, 0 checks, 173 lines checked

$ git checkout 143b51a80978 drivers/staging/iio/meter/ade7854.h # after
Updated 1 path from 21c208a36476a

$ ./scripts/checkpatch.pl --terse --types COMPLEX_MACRO \
drivers/staging/iio/meter/ade7854.h

$

> > Signed-off-by: daniel watson <ozzloy@...llenge-bot.com>
> 
> Capitalize your name?

I can remake this patch with my name capitalized if the patch is worth
remaking.  I'll be sure to capitalize in future sign-off lines for
Linux.

> This is not a real change that is needed, just look at the code to
> verify that.

Agreed, this is not a huge change.

I thought small changes were acceptable, if they get rid of errors from
checkpatch.  I got that impression from this video

Write and Submit your first Linux kernel Patch
https://youtu.be/LLBrBBImJt4

At around 15 minutes, you create a patch which removes curly braces
from an if-else.  That seemed comparable to the change in this
patch.  That video was posted over a decade ago, so I would understand
if things are different now.

> 
> thanks,
> 
> greg k-h

You're welcome!  Thank you too, that was a super fast response!  I am
happy to get a direct response from you!