linux-kernel - Re: [PATCH] staging: r8188eu: Add spaces before and after logical '&'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6957e465-7250-c5f4-759f-c802391268e0@gmail.com>
Date:   Tue, 17 Aug 2021 08:54:19 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     Abhishek Anand Kulkarni <kulkarniabhishekanand@...il.com>,
        gregkh@...uxfoundation.org
Cc:     Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Add spaces before and after logical '&'

On 8/17/21 4:26 AM, Abhishek Anand Kulkarni wrote:
> Fix Checkpatch.pl warning to add space before and after logical '&'
> operator
> 
> Signed-off-by: Abhishek Anand Kulkarni <kulkaraniabhishekanand@...il.com>
> ---
>   drivers/staging/r8188eu/core/rtw_ioctl_set.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_ioctl_set.c b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
> index a7f966a..570f25f 100644
> --- a/drivers/staging/r8188eu/core/rtw_ioctl_set.c
> +++ b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
> @@ -630,7 +630,7 @@ u8 rtw_set_802_11_add_key(struct adapter *padapter, struct ndis_802_11_key *key)
>   		struct ndis_802_11_wep *wep = &padapter->securitypriv.ndiswep;
>   
>   		wep->Length = len;
> -		keyindex = key->KeyIndex&0x7fffffff;
> +		keyindex = key->KeyIndex & 0x7fffffff;
>   		wep->KeyIndex = keyindex ;
>   		wep->KeyLength = key->KeyLength;
>   
> 

Hi Abhishek,

there is already a pending patch that addresses this.

https://lore.kernel.org/linux-staging/20210816155818.24005-9-straube.linux@gmail.com/T/#u

Regards,
Michael