linux-kernel - Re: [PATCH v2 3/3] staging: r8188eu: perform cleanup in rtl8188e_Add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9a12b30-07bf-0c73-4a32-b2f4703998f3@gmail.com>
Date:   Tue, 17 Aug 2021 09:05:43 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     Phillip Potter <phil@...lpotter.co.uk>, gregkh@...uxfoundation.org
Cc:     Larry.Finger@...inger.net, martin@...ser.cx,
        fmdefrancesco@...il.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] staging: r8188eu: perform cleanup in
 rtl8188e_Add_RateATid

On 8/17/21 1:44 AM, Phillip Potter wrote:
> Perform some cleanup items in the rtl8188e_Add_RateATid function:
> (1) Rename variable shortGIrate to short_gi_rate to comply with kernel
>      camel case rules.
> (2) Introduce additional whitespace around certain operators in the
>      function, to make it clearer what is happening.
> 
> Signed-off-by: Phillip Potter <phil@...lpotter.co.uk>
> ---
>   drivers/staging/r8188eu/hal/rtl8188e_cmd.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/hal/rtl8188e_cmd.c b/drivers/staging/r8188eu/hal/rtl8188e_cmd.c
> index 77c057e276a5..8d03b24dc5af 100644
> --- a/drivers/staging/r8188eu/hal/rtl8188e_cmd.c
> +++ b/drivers/staging/r8188eu/hal/rtl8188e_cmd.c
> @@ -155,25 +155,25 @@ void rtl8188e_Add_RateATid(struct adapter *pAdapter, u32 bitmap, u8 arg, u8 rssi
>   {
>   	struct hal_data_8188e *haldata = GET_HAL_DATA(pAdapter);
>   
> -	u8 macid, raid, shortGIrate = false;
> +	u8 macid, raid, short_gi_rate = false;
>   
> -	macid = arg&0x1f;
> +	macid = arg & 0x1f;
>   
> -	raid = (bitmap>>28) & 0x0f;
> +	raid = (bitmap >> 28) & 0x0f;
>   	bitmap &= 0x0fffffff;
>   
>   	if (rssi_level != DM_RATR_STA_INIT)
>   		bitmap = ODM_Get_Rate_Bitmap(&haldata->odmpriv, macid, bitmap, rssi_level);
>   
> -	bitmap |= ((raid<<28)&0xf0000000);
> +	bitmap |= ((raid << 28) & 0xf0000000);
>   
> -	shortGIrate = (arg&BIT(5)) ? true : false;
> +	short_gi_rate = (arg & BIT(5)) ? true : false;
>   
> -	raid = (bitmap>>28) & 0x0f;
> +	raid = (bitmap >> 28) & 0x0f;
>   
>   	bitmap &= 0x0fffffff;
>   
> -	ODM_RA_UpdateRateInfo_8188E(&haldata->odmpriv, macid, raid, bitmap, shortGIrate);
> +	ODM_RA_UpdateRateInfo_8188E(&haldata->odmpriv, macid, raid, bitmap, short_gi_rate);
>   }
>   
>   void rtl8188e_set_FwPwrMode_cmd(struct adapter *adapt, u8 Mode)
> 

Perhaps the added spaces around operators could conflict with
pending patch sets that address spacing style issues, otherwise...

Acked-by: Michael Straube <straube.linux@...il.com>

Thanks,
Michael