linux-kernel - Re: [PATCH] clk: add sys node to disable unused clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202108171941.L2GWsNSk-lkp@intel.com>
Date:   Tue, 17 Aug 2021 20:08:34 +0800
From:   kernel test robot <lkp@...el.com>
To:     Zhipeng Wang <zhipeng.wang_1@....com>, mturquette@...libre.com
Cc:     kbuild-all@...ts.01.org, sboyd@...nel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: add sys node to disable unused clk

Hi Zhipeng,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on v5.14-rc6 next-20210816]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Zhipeng-Wang/clk-add-sys-node-to-disable-unused-clk/20210813-094034
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: arc-randconfig-r011-20210812 (attached as .config)
compiler: arc-elf-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/166d814a2157788c7f7c7224b08ccdca8aaed7a0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Zhipeng-Wang/clk-add-sys-node-to-disable-unused-clk/20210813-094034
        git checkout 166d814a2157788c7f7c7224b08ccdca8aaed7a0
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/clk/clk.c: In function 'creat_sys_clk_unused':
>> drivers/clk/clk.c:1382:2: warning: ignoring return value of 'sysfs_create_groups' declared with attribute 'warn_unused_result' [-Wunused-result]
    1382 |  sysfs_create_groups(clk_ctrl_kobj, clk_ctrl_attr_groups);
         |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from include/linux/perf_event.h:25,
                    from include/linux/trace_events.h:10,
                    from include/trace/trace_events.h:21,
                    from include/trace/define_trace.h:102,
                    from include/trace/events/clk.h:270,
                    from drivers/clk/clk.c:96:
   At top level:
   arch/arc/include/asm/perf_event.h:126:23: warning: 'arc_pmu_cache_map' defined but not used [-Wunused-const-variable=]
     126 | static const unsigned arc_pmu_cache_map[C(MAX)][C(OP_MAX)][C(RESULT_MAX)] = {
         |                       ^~~~~~~~~~~~~~~~~
   arch/arc/include/asm/perf_event.h:91:27: warning: 'arc_pmu_ev_hw_map' defined but not used [-Wunused-const-variable=]
      91 | static const char * const arc_pmu_ev_hw_map[] = {
         |                           ^~~~~~~~~~~~~~~~~


vim +1382 drivers/clk/clk.c

  1377	
  1378	static int __init creat_sys_clk_unused(void)
  1379	{
  1380		struct kobject *clk_ctrl_kobj = kobject_create_and_add("clk_ctrl", NULL);
  1381	
> 1382		sysfs_create_groups(clk_ctrl_kobj, clk_ctrl_attr_groups);
  1383	
  1384		return 0;
  1385	}
  1386	late_initcall_sync(creat_sys_clk_unused);
  1387	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (27298 bytes)