linux-kernel - [hare-scsi-devel:eh-rework.v2 49/51] drivers/scsi/scsi_error.c:1207:6: warning: no previous prototype for '__scsi_eh_finish

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 17 Aug 2021 20:12:02 +0800
From:   kernel test robot <lkp@...el.com>
To:     Hannes Reinecke <hare@...e.de>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [hare-scsi-devel:eh-rework.v2 49/51]
 drivers/scsi/scsi_error.c:1207:6: warning: no previous prototype for
 '__scsi_eh_finish_cmd'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git eh-rework.v2
head:   7603e2e1f37e470064b8c865b5d6470137baa79b
commit: a5bf3d7edeb8669d4c307b527f1164788d7aefb8 [49/51] scsi: Move eh_device_reset_handler() to use scsi_device as argument
config: parisc-randconfig-r021-20210816 (attached as .config)
compiler: hppa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git/commit/?id=a5bf3d7edeb8669d4c307b527f1164788d7aefb8
        git remote add hare-scsi-devel https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git
        git fetch --no-tags hare-scsi-devel eh-rework.v2
        git checkout a5bf3d7edeb8669d4c307b527f1164788d7aefb8
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/scsi/scsi_error.c:1207:6: warning: no previous prototype for '__scsi_eh_finish_cmd' [-Wmissing-prototypes]
    1207 | void __scsi_eh_finish_cmd(struct scsi_cmnd *scmd, struct list_head *done_q,
         |      ^~~~~~~~~~~~~~~~~~~~


vim +/__scsi_eh_finish_cmd +1207 drivers/scsi/scsi_error.c

  1193	
  1194	/**
  1195	 * scsi_eh_finish_cmd - Handle a cmd that eh is finished with.
  1196	 * @scmd:	Original SCSI cmd that eh has finished.
  1197	 * @done_q:	Queue for processed commands.
  1198	 * @result:	Final command status to be set
  1199	 *
  1200	 * Notes:
  1201	 *    We don't want to use the normal command completion while we are are
  1202	 *    still handling errors - it may cause other commands to be queued,
  1203	 *    and that would disturb what we are doing.  Thus we really want to
  1204	 *    keep a list of pending commands for final completion, and once we
  1205	 *    are ready to leave error handling we handle completion for real.
  1206	 */
> 1207	void __scsi_eh_finish_cmd(struct scsi_cmnd *scmd, struct list_head *done_q,
  1208				int host_byte)
  1209	{
  1210		if (host_byte)
  1211			set_host_byte(scmd, host_byte);
  1212		list_move_tail(&scmd->eh_entry, done_q);
  1213	}
  1214	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (29966 bytes)