linux-kernel - Re: [PATCH] staging: r8188eu: Remove LINUX_VERSION

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20992337-fac8-64c8-887f-ee4cd79bf391@gmail.com>
Date:   Tue, 17 Aug 2021 14:24:55 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     Cai Huoqing <caihuoqing@...du.com>, Larry.Finger@...inger.net,
        phil@...lpotter.co.uk, gregkh@...uxfoundation.org,
        martin@...ser.cx, insafonov@...il.com
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Remove LINUX_VERSION_CODE check

On 8/17/21 10:12 AM, Cai Huoqing wrote:
> no need to check linux version, depending on the latest version
> 
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>
> ---
>   drivers/staging/r8188eu/core/rtw_mlme.c      |  5 ----
>   drivers/staging/r8188eu/os_dep/os_intfs.c    | 26 ++------------------
>   drivers/staging/r8188eu/os_dep/rtw_android.c |  6 -----
>   drivers/staging/r8188eu/os_dep/xmit_linux.c  |  6 -----
>   4 files changed, 2 insertions(+), 41 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c
> index 5088b555f55d..ef9d5ad17632 100644
> --- a/drivers/staging/r8188eu/core/rtw_mlme.c
> +++ b/drivers/staging/r8188eu/core/rtw_mlme.c
> @@ -3,7 +3,6 @@
>   
>   #define _RTW_MLME_C_
>   
> -#include <linux/version.h>
>   #include "../include/osdep_service.h"
>   #include "../include/drv_types.h"
>   #include "../include/recv_osdep.h"
> @@ -1499,11 +1498,7 @@ void rtw_dynamic_check_timer_handlder(struct adapter *adapter)
>   

Hi Cai,

the LINUX_VERSION_CODE checks already have been removed in commit

027ed956b526 ("staging: r8188eu: remove kernel version depended code paths")

But I forgot to remove the <linux/version.h> includes, nicely spotted.
You can send a patch that removes them. :)

Thanks,
Michael