linux-kernel - Re: [PATCH v2 3/3] soc: rockchip: io-domain: do more thing about regulator notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210817143612.GB4290@sirena.org.uk>
Date:   Tue, 17 Aug 2021 15:36:12 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Jianqun Xu <jay.xu@...k-chips.com>
Cc:     lgirdwood@...il.com, ulf.hansson@...aro.org, lee.jones@...aro.org,
        zhangchangzhong@...wei.com, heiko@...ech.de,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] soc: rockchip: io-domain: do more thing about
 regulator notify

On Tue, Aug 17, 2021 at 11:38:48AM +0800, Jianqun Xu wrote:

> +	} else if (event & REGULATOR_EVENT_ENABLE) {
> +		uV = regulator_get_voltage(supply->reg);
>  	} else {

I am very surprised this doesn't cause locking issues given that we
might call notifiers with the regulator API's locks held.  Have you
tested this with lockdep on?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)