linux-kernel - Re: [PATCH v2 7/8] um: add PCI over virtio emulation driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46d3c77cb6fcc686d3f3110eb2412f3fd2e682dc.camel@sipsolutions.net>
Date:   Tue, 17 Aug 2021 17:51:27 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     linux-um@...ts.infradead.org, Arnd Bergmann <arnd@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 7/8] um: add PCI over virtio emulation driver

Hi,

> The virtio_pcidev_ops kernel-doc below doesn't match the actual enum,
> so it generates several warnings:
> 
>   include/uapi/linux/virtio_pcidev.h:41: warning: Enum value 'VIRTIO_PCIDEV_OP_RESERVED' not described in enum 'virtio_pcidev_ops'
>   include/uapi/linux/virtio_pcidev.h:41: warning: Enum value 'VIRTIO_PCIDEV_OP_MMIO_READ' not described in enum 'virtio_pcidev_ops'
>   include/uapi/linux/virtio_pcidev.h:41: warning: Enum value 'VIRTIO_PCIDEV_OP_MMIO_WRITE' not described in enum 'virtio_pcidev_ops'
>   include/uapi/linux/virtio_pcidev.h:41: warning: Excess enum value 'VIRTIO_PCIDEV_OP_BAR_READ' description in 'virtio_pcidev_ops'
>   include/uapi/linux/virtio_pcidev.h:41: warning: Excess enum value 'VIRTIO_PCIDEV_OP_BAR_WRITE' description in 'virtio_pcidev_ops'
> 
> FWIW, here's the command I used to find these:
> 
>   $ find include drivers/pci -type f -path "*pci*.[ch]" | xargs scripts/kernel-doc -none

Oops. It didn't get tied to any real doc creation so I guess the bots
didn't find it, but I'll send a patch to fix it, thanks!

johannes