linux-kernel - Re: [PATCH 0/2] staging: rtl8732bs: Fix sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Aug 2021 19:54:11 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Aakash Hemadri <aakashhemadri123@...il.com>
Cc:     Shuah Khan <skhan@...uxfoundation.org>,
        Bjorn Helgaas <bjorn@...gaas.com>,
        linux-staging@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] staging: rtl8732bs: Fix sparse warnings

On Mon, Aug 16, 2021 at 11:00:41PM +0530, Aakash Hemadri wrote:
> This patchset fixes the below sparse warnings
> 
> rtw_security.c:72:50: warning: incorrect type in assignment (different base types)
> rtw_security.c:72:50:    expected restricted __le32 [usertype]
> rtw_security.c:72:50:    got unsigned int
> rtw_security.c:80:50: warning: incorrect type in assignment (different base types)
> rtw_security.c:80:50:    expected restricted __le32 [usertype]
> rtw_security.c:80:50:    got unsigned int
> rtw_security.c:124:33: warning: cast to restricted __le32
> rtw_security.c:509:58: warning: incorrect type in assignment (different base types)
> rtw_security.c:509:58:    expected restricted __le32 [usertype]
> rtw_security.c:509:58:    got unsigned int
> rtw_security.c:517:58: warning: incorrect type in assignment (different base types)
> rtw_security.c:517:58:    expected restricted __le32 [usertype]
> rtw_security.c:517:58:    got unsigned int
> rtw_security.c:621:41: warning: cast to restricted __le32
> 
> This can be applied cleanly on next-20210816, and is compile tested.
> 
> Aakash Hemadri (2):
>   staging: rtl8732bs: incorrect type in assignment
>   staging: rtl8723bs: cast to restricted __le32
> 
>  rtw_security.c | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)

This series does not apply to my tree at all.  Please fix up and rebase
and resubmit, after reading the mailing list archives for others that
have attempted do do this type of work in the past for this issue.

It is not a trivial change that is needed...

thanks,

greg k-h