linux-kernel - Re: [PATCH 1/2] ALSA: hda/sigmatel - Sink stac_shutup() into stac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hpmubcnbn.wl-tiwai@suse.de>
Date:   Wed, 18 Aug 2021 07:51:40 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Nathan Chancellor <nathan@...nel.org>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ALSA: hda/sigmatel - Sink stac_shutup() into stac_suspend()

On Wed, 18 Aug 2021 03:27:04 +0200,
Nathan Chancellor wrote:
> 
> When CONFIG_PM is not set, there is an unused function warning:
> 
> sound/pci/hda/patch_sigmatel.c:4383:13: warning: unused function
> 'stac_shutup' [-Wunused-function]
> static void stac_shutup(struct hda_codec *codec)
>             ^
> 1 warning generated.
> 
> Sink the contents of stac_shutup() into stac_suspend() since
> stac_shutup() is only called in that one location now.
> 
> Fixes: 327b34f2a97d ("ALSA: hda: Nuke unused reboot_notify callback")
> Signed-off-by: Nathan Chancellor <nathan@...nel.org>

Thanks, applied.


Takashi