linux-kernel - Re: [PATCH 1/2] net: mii: make mii_ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Aug 2021 11:50:10 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Pavel Skripkin <paskripkin@...il.com>, davem@...emloft.net,
        christophe.jaillet@...adoo.fr, jesse.brandeburg@...el.com,
        kaixuxia@...cent.com, lee.jones@...aro.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] net: mii: make mii_ethtool_gset() return void

On Tue, Aug 17, 2021 at 05:39:04PM -0700, Jakub Kicinski wrote:
> On Tue, 17 Aug 2021 21:34:42 +0300 Pavel Skripkin wrote:
> > mii_ethtool_gset() does not return any errors. We can make it return
> > void to simplify error checking in drivers, that rely on return value
> > of this function.
> > 
> > Signed-off-by: Pavel Skripkin <paskripkin@...il.com>
> 
> This breaks the build and therefore would be a nuisance in bisection.
> Please squash the changes or invert the order.

Please invert the order. You will need slightly different justification for the
PCH GBE patch. Feel free to add my

Acked-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

to the PCH GBE one.

-- 
With Best Regards,
Andy Shevchenko