linux-kernel - Re: [PATCH] lib/vsprintf: don't increment buf in bitmap_list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YRzQHkF8inFrdfQM@smile.fi.intel.com>
Date:   Wed, 18 Aug 2021 12:17:18 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Yury Norov <yury.norov@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, Petr Mladek <pmladek@...e.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH] lib/vsprintf: don't increment buf in bitmap_list_string

On Tue, Aug 17, 2021 at 12:37:35PM -0700, Yury Norov wrote:

Thanks!

> Increment is confusing as the buf is overritten at the same line.

> Fixes: b1c4af4d3d6b (vsprintf: rework bitmap_list_string) (next-20210817)

Fixes tag has its special format. I don't think we need it here, just to ask
Andrew in comments that it needs to be folded.

-- 
With Best Regards,
Andy Shevchenko