linux-kernel - Re: [PATCH RESEND 1/2] ARM: tegra: paz00: Handle device properties with software node API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 18 Aug 2021 12:57:28 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Thierry Reding <thierry.reding@...il.com>
Cc:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND 1/2] ARM: tegra: paz00: Handle device properties
 with software node API

On Tue, Aug 17, 2021 at 04:30:44PM +0200, Thierry Reding wrote:
> On Tue, Aug 17, 2021 at 01:24:48PM +0300, Heikki Krogerus wrote:
> > The old device property API is going to be removed.
> > Replacing the device_add_properties() call with the software
> > node API equivalent, device_create_managed_software_node().
> > 
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> > ---
> >  arch/arm/mach-tegra/board-paz00.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/mach-tegra/board-paz00.c b/arch/arm/mach-tegra/board-paz00.c
> > index b5c990a7a5af5..18d37f90cdfe3 100644
> > --- a/arch/arm/mach-tegra/board-paz00.c
> > +++ b/arch/arm/mach-tegra/board-paz00.c
> > @@ -36,7 +36,7 @@ static struct gpiod_lookup_table wifi_gpio_lookup = {
> >  
> >  void __init tegra_paz00_wifikill_init(void)
> >  {
> > -	platform_device_add_properties(&wifi_rfkill_device, wifi_rfkill_prop);
> > +	device_create_managed_software_node(&wifi_rfkill_device.dev, wifi_rfkill_prop, NULL);
> >  	gpiod_add_lookup_table(&wifi_gpio_lookup);
> >  	platform_device_register(&wifi_rfkill_device);
> >  }
> 
> Seems alright. Looks to be doing mostly the same thing as the original
> platform_device_add_properties() was doing, except for the node now
> being managed, which is irrelevant in this context.
> 
> I'm fine with Greg picking this up. I'm not aware of any other changes
> to this file that might cause a conflict for v5.15.
> 
> Acked-by: Thierry Reding <treding@...dia.com>

I'll pick it up, thanks!

greg k-h