linux-kernel - [PATCH] x86: kvm: Demote level of already loaded message from error to info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210818114956.7171-1-pmenzel@molgen.mpg.de>
Date:   Wed, 18 Aug 2021 13:49:56 +0200
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     Paolo Bonzini <pbonzini@...hat.com>,
        Sean Christopherson <seanjc@...gle.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>
Cc:     Paul Menzel <pmenzel@...gen.mpg.de>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] x86: kvm: Demote level of already loaded message from error to info

In scripts, running

    modprobe kvm_amd     2>/dev/null
    modprobe kvm_intel   2>/dev/null

to ensure the modules are loaded causes Linux to log errors.

    $ dmesg --level=err
    [    0.641747] [Firmware Bug]: TSC_DEADLINE disabled due to Errata; please update microcode to version: 0x3a (or later)
    [   40.196868] kvm: already loaded the other module
    [   40.219857] kvm: already loaded the other module
    [   55.501362] kvm [1177]: vcpu0, guest rIP: 0xffffffff96e5b644 disabled perfctr wrmsr: 0xc2 data 0xffff
    [   56.397974] kvm [1418]: vcpu0, guest rIP: 0xffffffff81046158 disabled perfctr wrmsr: 0xc1 data 0xabcd
    [1007981.827781] kvm: already loaded the other module
    [1008000.394089] kvm: already loaded the other module
    [1008030.706999] kvm: already loaded the other module
    [1020396.054470] kvm: already loaded the other module
    [1020405.614774] kvm: already loaded the other module
    [1020410.140069] kvm: already loaded the other module
    [1020704.049231] kvm: already loaded the other module

As one of the two KVM modules is already loaded, KVM is functioning, and
their is no error condition. Therefore, demote the log message level to
informational.

Signed-off-by: Paul Menzel <pmenzel@...gen.mpg.de>
---
 arch/x86/kvm/x86.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index e5d5c5ed7dd4..411c58ae0c97 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -8372,7 +8372,7 @@ int kvm_arch_init(void *opaque)
 	int r;
 
 	if (kvm_x86_ops.hardware_enable) {
-		printk(KERN_ERR "kvm: already loaded the other module\n");
+		printk(KERN_INFO "kvm: already loaded the other module\n");
 		r = -EEXIST;
 		goto out;
 	}
-- 
2.33.0