linux-kernel - Re: [PATCH v3] soc: rockchip: io-domain: set 3.3V before regulator disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210818122715.GE4177@sirena.org.uk>
Date:   Wed, 18 Aug 2021 13:27:15 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Jianqun Xu <jay.xu@...k-chips.com>
Cc:     lgirdwood@...il.com, ulf.hansson@...aro.org, lee.jones@...aro.org,
        zhangchangzhong@...wei.com, heiko@...ech.de,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] soc: rockchip: io-domain: set 3.3V before regulator
 disable

On Wed, Aug 18, 2021 at 09:09:56AM +0800, Jianqun Xu wrote:

> +	} else if (event & REGULATOR_EVENT_ENABLE) {
> +		uV = regulator_get_voltage(supply->reg);

I'm still not clear that the locking is safe here - the notifier is
called with the regulator lock held but regulator_get_voltage() wants to
take that lock.  Have you tried this with the various lock debugging
stuff turned on?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)