linux-kernel - Re: [PATCH] fpga: machxo2-spi: Fix missing error code in machxo2_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJYdmeN5WHYx+mczUfkYbeWpRNwevDR5njxttW+4PuBw2Muf6w@mail.gmail.com>
Date:   Tue, 17 Aug 2021 19:47:08 -0700
From:   Moritz Fischer <moritz.fischer.private@...il.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     Tom Rix <trix@...hat.com>, linux-fpga@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fpga: machxo2-spi: Fix missing error code in machxo2_write_complete()

On Thu, Aug 12, 2021 at 11:41 PM Jiapeng Chong
<jiapeng.chong@...ux.alibaba.com> wrote:
>
> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'ret'.
>
> Eliminate the follow smatch warning:
>
> drivers/fpga/machxo2-spi.c:341 machxo2_write_complete() warn: missing
> error code 'ret'.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Fixes: 88fb3a002330 ("fpga: lattice machxo2: Add Lattice MachXO2
> support")
This shouldn't line-break.
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  drivers/fpga/machxo2-spi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/fpga/machxo2-spi.c b/drivers/fpga/machxo2-spi.c
> index b4a530a..ea2ec3c 100644
> --- a/drivers/fpga/machxo2-spi.c
> +++ b/drivers/fpga/machxo2-spi.c
> @@ -338,6 +338,7 @@ static int machxo2_write_complete(struct fpga_manager *mgr,
>                         break;
>                 if (++refreshloop == MACHXO2_MAX_REFRESH_LOOP) {
>                         machxo2_cleanup(mgr);
> +                       ret = -EINVAL;
>                         goto fail;
>                 }
>         } while (1);
> --
> 1.8.3.1
>

Applied to 'fixes' with modifications to commit message,

Moritz