lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Aug 2021 19:56:42 -0700 From: Saravana Kannan <saravanak@...gle.com> To: Andrew Lunn <andrew@...n.ch> Cc: Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Marc Zyngier <maz@...nel.org>, Neil Armstrong <narmstrong@...libre.com>, Kevin Hilman <khilman@...libre.com>, kernel-team@...roid.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net v2 1/3] net: mdio-mux: Delete unnecessary devm_kfree On Tue, Aug 17, 2021 at 2:10 PM Andrew Lunn <andrew@...n.ch> wrote: > > On Tue, Aug 17, 2021 at 11:08:39AM -0700, Saravana Kannan wrote: > > The whole point of devm_* APIs is that you don't have to undo them if you > > are returning an error that's going to get propagated out of a probe() > > function. So delete unnecessary devm_kfree() call in the error return path. > > > > Signed-off-by: Saravana Kannan <saravanak@...gle.com> > > Reviewed-by: Andrew Lunn <andrew@...n.ch> > > Acked-by: Marc Zyngier <maz@...nel.org> > > Tested-by: Marc Zyngier <maz@...nel.org> > > Acked-by: Kevin Hilman <khilman@...libre.com> > > Tested-by: Kevin Hilman <khilman@...libre.com> > > Please add a Fixes: tag, since you want this in stable. > > All three patches need fixes tags, possibly different for each patch? I generally ask for patches to be picked up by stable only if it fixes a bug that puts the kernel in a bad state or if it fixes an issue someone actually reported on the stable kernel. In this case, it's just failing device probes in some cases and I didn't think that met the bar for stable. But if you think they should, then that's fine by me. I'll send out v3 patches with Fixes. I'm fairly sure these issues were present since the time mdio-mux was added. Hopefully v3 will be the last version I have to send out :) -Saravana
Powered by blists - more mailing lists