linux-kernel - Re: [PATCH] RDMA/bnxt_re: Remove redundant unlock in bnxt_re_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210819180220.GA366515@nvidia.com>
Date:   Thu, 19 Aug 2021 15:02:20 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Dinghao Liu <dinghao.liu@....edu.cn>
Cc:     kjlu@....edu, Selvin Xavier <selvin.xavier@...adcom.com>,
        Naresh Kumar PBS <nareshkumar.pbs@...adcom.com>,
        Doug Ledford <dledford@...hat.com>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RDMA/bnxt_re: Remove redundant unlock in bnxt_re_dev_init

On Mon, Aug 16, 2021 at 04:55:31PM +0800, Dinghao Liu wrote:
> Commit c2b777a95923 removes all rtnl_lock() and rtnl_unlock()
> in function bnxt_re_dev_init(), but forgets to remove a rtnl_unlock()
> in the error handling path of bnxt_re_register_netdev(), which may
> cause a deadlock. This bug is suggested by a static analysis tool,
> please advise.
> 
> Fixes: c2b777a95923 ("RDMA/bnxt_re: Refactor device add/remove functionalities")
> Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
> Acked-by: Selvin Xavier <selvin.xavier@...adcom.com>
> ---
>  drivers/infiniband/hw/bnxt_re/main.c | 1 -
>  1 file changed, 1 deletion(-)

Applied to for-rc, thanks

Jason