linux-kernel - Re: [PATCH v2 2/2] scsi: qla1280: Fix DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7107778e-8e20-22ab-bf94-d26aca09bd93@acm.org>
Date:   Thu, 19 Aug 2021 11:07:53 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     John Garry <john.garry@...wei.com>, mdr@....com,
        jejb@...ux.ibm.com, martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        hare@...e.de
Subject: Re: [PATCH v2 2/2] scsi: qla1280: Fix DEBUG_QLA1280 compilation
 issues

On 8/19/21 2:32 AM, John Garry wrote:
> The driver does not compile under DEBUG_QLA1280 flag:
> - Debug statements expect an integer for printing a SCSI lun value, but
>    its size is 64b. So change SCSI_LUN_32() to cast to an int, as would be
>    expected from a "_32" function.
> - lower_32_bits() expects %x, as opposed to %lx, so fix that.
> 
> Also delete ql1280_dump_device(), which looks to have never been
> referenced.
> 
> Signed-off-by: John Garry <john.garry@...wei.com>
> ---
>   drivers/scsi/qla1280.c | 27 ++-------------------------
>   1 file changed, 2 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
> index b4f7d8d7a01c..9a7e84b49d41 100644
> --- a/drivers/scsi/qla1280.c
> +++ b/drivers/scsi/qla1280.c
> @@ -494,7 +494,7 @@ __setup("qla1280=", qla1280_setup);
>   #define CMD_HOST(Cmnd)		Cmnd->device->host
>   #define SCSI_BUS_32(Cmnd)	Cmnd->device->channel
>   #define SCSI_TCN_32(Cmnd)	Cmnd->device->id
> -#define SCSI_LUN_32(Cmnd)	Cmnd->device->lun
> +#define SCSI_LUN_32(Cmnd)	((int)Cmnd->device->lun)

How about using 'unsigned int' instead of 'int' since LUN numbers are 
positive integers?

Thanks,

Bart.