linux-kernel - Re: [PATCH] mm: vmscan: consistent update to pgdeactivate and pgactivate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALvZod5m3PE1vBEaW+FoiByYHGJZiDF5TR-33dGXpH7BNNcvWw@mail.gmail.com>
Date:   Thu, 19 Aug 2021 13:26:55 -0700
From:   Shakeel Butt <shakeelb@...gle.com>
To:     Hao Lee <haolee.swjtu@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Linux MM <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: vmscan: consistent update to pgdeactivate and pgactivate

On Thu, Aug 19, 2021 at 9:31 AM Hao Lee <haolee.swjtu@...il.com> wrote:
>
> After the commit 912c05720f00 ("mm: vmscan: consistent update to
> pgrefill"), pgrefill is consistent with pgscan and pgsteal. Only under
> global reclaim, are they updated at system level. Apart from that,
> pgdeactivate is often used together with pgrefill to measure the
> deactivation efficiency and pgactivate is used together with
> pgscan to measure the reclaim efficiency. It's also necessary to
> make pgdeactivate and pgactivate consistent with this rule.
>
> Signed-off-by: Hao Lee <haolee@...iglobal.com>

pgactivate and pgdeactivate are also updated in code paths other than
memory reclaim like mark_page_accessed() or madvise(COLD). Wouldn't
that impact your analysis of these metrics as well?