linux-kernel - Re: Revert "video: fbdev: mxsfb: Remove driver"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Aug 2021 08:36:49 +1000
From:   Alistair Francis <alistair23@...il.com>
To:     Sam Ravnborg <sam@...nborg.org>
Cc:     Marek Vasut <marex@...x.de>, Fabio Estevam <festevam@...il.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>, b.zolnierkie@...sung.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Alistair Francis <alistair@...stair23.me>
Subject: Re: Revert "video: fbdev: mxsfb: Remove driver"

On Fri, Aug 20, 2021 at 1:43 AM Sam Ravnborg <sam@...nborg.org> wrote:
>
> Hi Alistair,
>
> On Thu, Aug 19, 2021 at 07:10:00PM +1000, Alistair Francis wrote:
> > On Thu, Aug 19, 2021 at 4:38 AM Sam Ravnborg <sam@...nborg.org> wrote:
> > >
> > > Hi Alistair,
> > >
> > > >
> > > > These are the EINVAL strace tells me in the not working case:
> > > >
> > > > prctl(PR_CAPBSET_READ, 0x30 /* CAP_??? */) = -1 EINVAL (Invalid argument)
> > > > prctl(PR_CAPBSET_READ, 0x2c /* CAP_??? */) = -1 EINVAL (Invalid argument)
> > > > prctl(PR_CAPBSET_READ, 0x2a /* CAP_??? */) = -1 EINVAL (Invalid argument)
> > > > prctl(PR_CAPBSET_READ, 0x29 /* CAP_??? */) = -1 EINVAL (Invalid argument)
> > > > ioctl(5, FBIOPUT_VSCREENINFO, 0x4ce8e0) = -1 EINVAL (Invalid argument)
> > > >
> > > > I'm guessing it's related to FBIOPUT_VSCREENINFO then, is that
> > > > something that could be added to the DRM emulation?
> > >
> > > If it turns out FBIOPUT_VSCREENINFO is the culprint it would also be
> > > good to know why we see EINVAL.
> > > One way is to sprinkle a number of printk's in fb_set_var(),
> > > then you can see how far you get before it fails.
> >
> > Thanks for the help.
> >
> > I see this line:
> >
> > ret = info->fbops->fb_check_var(var, info);
> >
> > in fb_set_var()
> >
> > returning early.
>
> Super, then next step is to annotate drm_fb_helper_check_var()
> to see where it fails.
> Try this and let us know the result.

Thanks!

After adding some prints, I realised there are already some in there
that are disabled by default. After enabling them I see this:

"fbdev emulation doesn't support changing the pixel clock, value of
pixclock is ignored"

and

"fb requested width/height/bpp can't fit in current fb request
260x1408-32 (virtual 260x23936) > 334x1405-32"

which returns EINVAL.

This is where I'm confused though. The values 334 and 1405 are taken
from the vendor and in the working fbdev driver they are using the
same values.

I tried to add a similar print to mxsfb_check_var() for the working
version, to check what the values are, but there doesn't seem to be
any equivalent of fb->width and friends.

Any ideas?

Alistair

>
>         Sam