linux-kernel - Re: [PATCH] PCI: uniphier: Take lock in INTX irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6ae226a6-dc3d-94da-a356-6bd78053de06@socionext.com>
Date:   Fri, 20 Aug 2021 08:03:02 +0900
From:   Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Pali Rohár <pali@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        linux-pci@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: uniphier: Take lock in INTX irq_{mask,unmask,ack}
 callbacks

Hi Bjorn,
Thank you for checking.

On 2021/08/19 20:29, Bjorn Helgaas wrote:
> Possibly update subject to be more descriptive, along lines of:
> 
>    Serialize INTx masking/unmasking

Okay, I'll apply it to the subject.

> On Thu, Aug 19, 2021 at 07:56:06PM +0900, Kunihiko Hayashi wrote:
>> The same condition register PCI_RCV_INTX is used in irq_mask(),
>> irq_unmask() and irq_ack() callbacks. Accesses to register can occur at the
>> same time without lock.
>> This introduces a lock into the callbacks to prevent the issue.
> 
> Rewrap into a single paragraph or add blank line between paragraphs.
> 
> s/This introduces/Add/ to make this an imperative description of what
> you want this patch to do.  No need for "This" since the context is
> obvious.

I see. I'll rewrite the message to convey it more directly.

Thank you,

---
Best Regards
Kunihiko Hayashi