lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 19 Aug 2021 16:58:52 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Eryu Guan <eguan@...ux.alibaba.com>
Cc:     Eryu Guan <guan@...u.me>, fstests@...r.kernel.org, hare@...e.de,
        dgilbert@...erlog.com, jeyu@...nel.org, lucas.demarchi@...el.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] common/module: add patient module rmmod support

On Thu, Aug 19, 2021 at 10:26:44AM +0800, Eryu Guan wrote:
> On Wed, Aug 18, 2021 at 07:02:56AM -0700, Luis Chamberlain wrote:
> > On Sun, Aug 15, 2021 at 08:29:42PM +0800, Eryu Guan wrote:
> > > 
> > > Use "$max_tries -ne 0" to check inters seems better.
> > 
> > max_tries can be "forever", in which case this is -eq 0:
> > 
> > $ foo="forever"; if [[ $foo -eq 0 ]]; then echo buggy; else echo ok; fi
> > buggy
> 
> I see, that makes sense. Then perhaps some comments would help.

I had sent out a v3 before seeing this request. I'll send a v4 with 
a comment clarifying this.

  Luis

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ