linux-kernel - Re: [PATCH v3 06/20] platform/x86: intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdtXa=WXEFmvDP+zjmodzvJ+FmOpVZ6dq0C=nKnK=_zXA@mail.gmail.com>
Date:   Thu, 19 Aug 2021 15:08:51 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Kate Hsuan <hpa@...hat.com>
Cc:     Alex Hung <alex.hung@...onical.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <mgross@...ux.intel.com>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        AceLan Kao <acelan.kao@...onical.com>,
        Jithu Joseph <jithu.joseph@...el.com>,
        Maurice Ma <maurice.ma@...el.com>,
        Sujith Thomas <sujith.thomas@...el.com>,
        Rajneesh Bhardwaj <irenic.rajneesh@...il.com>,
        Zha Qipeng <qipeng.zha@...el.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        "David E . Box" <david.e.box@...ux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Dell.Client.Kernel@...l.com,
        Platform Driver <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH v3 06/20] platform/x86: intel_scu: Move to intel sub-directory

On Thu, Aug 19, 2021 at 6:33 AM Kate Hsuan <hpa@...hat.com> wrote:
>
> Move intel_scu to intel sub-directory to improve readability.

Intel SCU

...

> -obj-$(CONFIG_INTEL_SCU_IPC)            += intel_scu_ipc.o
> -obj-$(CONFIG_INTEL_SCU_PCI)            += intel_scu_pcidrv.o
> -obj-$(CONFIG_INTEL_SCU_PLATFORM)       += intel_scu_pltdrv.o
> -obj-$(CONFIG_INTEL_SCU_WDT)            += intel_scu_wdt.o
> -obj-$(CONFIG_INTEL_SCU_IPC_UTIL)       += intel_scu_ipcutil.o

> +

Stray change?

...

> +obj-$(CONFIG_INTEL_SCU_IPC)            += scu/
> +obj-$(CONFIG_INTEL_SCU_PCI)            += scu/
> +obj-$(CONFIG_INTEL_SCU_PLATFORM)       += scu/
> +obj-$(CONFIG_INTEL_SCU_WDT)            += scu/
> +obj-$(CONFIG_INTEL_SCU_IPC_UTIL)       += scu/

One entry is enough.

...

> +obj-$(CONFIG_INTEL_SCU_IPC)            += ipc.o
> +obj-$(CONFIG_INTEL_SCU_PCI)            += pcidrv.o
> +obj-$(CONFIG_INTEL_SCU_WDT)            += wdt.o

This is not an equivalent. Please, use the same approach as below.

> +intel_scu_pltdrv-y                     := pltdrv.o
> +obj-$(CONFIG_INTEL_SCU_PLATFORM)       += intel_scu_pltdrv.o
> +intel_scu_ipcutil-y                    := ipcutil.o
> +obj-$(CONFIG_INTEL_SCU_IPC_UTIL)       += intel_scu_ipcutil.o

-- 
With Best Regards,
Andy Shevchenko