linux-kernel - Re: [PATCH] mm: vmscan: fix missing psi annotation for node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALvZod5y4WquXhH6BdVAyqMNqxCm=RGkOk-iBkRuW0uQPCz_1g@mail.gmail.com>
Date:   Thu, 19 Aug 2021 08:04:19 -0700
From:   Shakeel Butt <shakeelb@...gle.com>
To:     Johannes Weiner <hannes@...xchg.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Rik van Riel <riel@...riel.com>,
        Linux MM <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH] mm: vmscan: fix missing psi annotation for node_reclaim()

On Wed, Aug 18, 2021 at 8:26 AM Johannes Weiner <hannes@...xchg.org> wrote:
>
> In a debugging session the other day, Rik noticed that node_reclaim()
> was missing memstall annotations. This means we'll miss pressure and
> lost productivity resulting from reclaim on an overloaded local NUMA
> node when vm.zone_reclaim_mode is enabled.
>
> There haven't been any reports, but that's likely because
> vm.zone_reclaim_mode hasn't been a commonly used feature recently, and
> the intersection between such setups and psi users is probably
> nil. Although, secondary memory such as CXL-connected DIMMS,
> persistent memory etc. and the page demotion patches that handle them
> (https://lore.kernel.org/lkml/20210401183216.443C4443@viggo.jf.intel.com/)
> could soon make this a more common codepath again.
>
> Reported-by: Rik van Riel <riel@...riel.com>
> Signed-off-by: Johannes Weiner <hannes@...xchg.org>

Reviewed-by: Shakeel Butt <shakeelb@...gle.com>