linux-kernel - Re: [BUG] fs: dlm: possible ABBA deadlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210819155509.GB21218@redhat.com>
Date:   Thu, 19 Aug 2021 10:55:09 -0500
From:   David Teigland <teigland@...hat.com>
To:     Jia-Ju Bai <baijiaju1990@...il.com>
Cc:     cluster-devel@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [BUG] fs: dlm: possible ABBA deadlock

On Thu, Aug 19, 2021 at 04:54:57PM +0800, Jia-Ju Bai wrote:
> Hello,
> 
> My static analysis tool reports a possible ABBA deadlock in the dlm
> filesystem in Linux 5.10:
> 
> dlm_recover_waiters_pre()
>   mutex_lock(&ls->ls_waiters_mutex); --> line 5130
>   recover_convert_waiter()
>     _receive_convert_reply()
>       lock_rsb()
>         mutex_lock(&r->res_mutex); --> line 69
> 
> dlm_recover_waiters_post()
>   lock_rsb()
>     mutex_lock(&r->res_mutex); --> line 69
>   mutex_lock(&ls->ls_waiters_mutex); --> line 5307
> 
> When dlm_recover_waiters_pre() and dlm_recover_waiters_post() are
> concurrently executed, the deadlock can occur.
> 
> I am not quite sure whether this possible deadlock is real and how to fix it
> if it is real.
> Any feedback would be appreciated, thanks :)

They won't be concurrent, "pre" runs before recovery, and "post" is after.
Dave