linux-kernel - Re: [PATCH] TDA1997x: fix tda1997x_query_dv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ+vNU35OoSs+AcV0xFmae1CPn9T+3tbs29YxmXC17WgO+vSXQ@mail.gmail.com>
Date:   Thu, 19 Aug 2021 09:48:10 -0700
From:   Tim Harvey <tharvey@...eworks.com>
To:     Krzysztof Hałasa <khalasa@...p.pl>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media <linux-media@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] TDA1997x: fix tda1997x_query_dv_timings() return value

On Mon, Jul 26, 2021 at 3:46 AM Krzysztof Hałasa <khalasa@...p.pl> wrote:
>
> Signed-off-by: Krzysztof Hałasa <khalasa@...p.pl>
>
> diff --git a/drivers/media/i2c/tda1997x.c b/drivers/media/i2c/tda1997x.c
> index 043cc8275d00..cbfe58e413e9 100644
> --- a/drivers/media/i2c/tda1997x.c
> +++ b/drivers/media/i2c/tda1997x.c
> @@ -1695,14 +1695,15 @@ static int tda1997x_query_dv_timings(struct v4l2_subdev *sd,
>                                      struct v4l2_dv_timings *timings)
>  {
>         struct tda1997x_state *state = to_state(sd);
> +       int ret;
>
>         v4l_dbg(1, debug, state->client, "%s\n", __func__);
>         memset(timings, 0, sizeof(struct v4l2_dv_timings));
>         mutex_lock(&state->lock);
> -       tda1997x_detect_std(state, timings);
> +       ret = tda1997x_detect_std(state, timings);
>         mutex_unlock(&state->lock);
>
> -       return 0;
> +       return ret;
>  }
>
>  static const struct v4l2_subdev_video_ops tda1997x_video_ops = {

Krzysztof,

Patch looks good to me but needs a commit log.

Best regards,

Tim