linux-kernel - Re: [PATCH -next] iio: adc: add missing clk_disable_unprepare() in rzg2l_adc_pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vd22aP098s9iXCGmBG505dW1vmZgvy3h9NoNA=J-eQ-CQ@mail.gmail.com>
Date:   Thu, 19 Aug 2021 20:20:58 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
        prabhakar.mahadev-lad.rj@...renesas.com, jic23@...nel.org
Subject: Re: [PATCH -next] iio: adc: add missing clk_disable_unprepare() in rzg2l_adc_pm_runtime_resume()

On Thu, Aug 19, 2021 at 4:19 PM Yang Yingliang <yangyingliang@...wei.com> wrote:
>
> Add clk_disable_unprepare() on error path in rzg2l_adc_pm_runtime_resume().

...

>         ret = clk_prepare_enable(adc->adclk);
> -       if (ret)
> +       if (ret) {
> +               clk_disable_unprepare(adc->pclk);
>                 return ret;
> +       }

Huh?!

-- 
With Best Regards,
Andy Shevchenko