linux-kernel - Re: [PATCH] block: use enumerate instead of integer in op_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YR870nMzpojlhR3l@infradead.org>
Date:   Fri, 20 Aug 2021 06:21:22 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     brookxu <brookxu.cn@...il.com>
Cc:     axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: use enumerate instead of integer in op_is_write()

On Fri, Aug 20, 2021 at 09:55:12AM +0800, brookxu wrote:
> From: Chunguang Xu <brookxu@...cent.com>
> 
> For mask operation, using enumerate may be safer than integer.

Except that we are explicitly checking for least significant bit as
that is part of the encoding, not a specific enum value.