linux-kernel - RE: [PATCH -next] iio: adc: add missing clk_disable_unprepare() in rzg2l_adc_pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR03MB635988DC2F6E54D545337FDF99C19@SJ0PR03MB6359.namprd03.prod.outlook.com>
Date:   Fri, 20 Aug 2021 06:46:59 +0000
From:   "Sa, Nuno" <Nuno.Sa@...log.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Yang Yingliang <yangyingliang@...wei.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "prabhakar.mahadev-lad.rj@...renesas.com" 
        <prabhakar.mahadev-lad.rj@...renesas.com>,
        "jic23@...nel.org" <jic23@...nel.org>
Subject: RE: [PATCH -next] iio: adc: add missing clk_disable_unprepare() in
 rzg2l_adc_pm_runtime_resume()

> From: Andy Shevchenko <andy.shevchenko@...il.com>
> Sent: Thursday, August 19, 2021 7:21 PM
> To: Yang Yingliang <yangyingliang@...wei.com>
> Cc: linux-kernel@...r.kernel.org; linux-iio@...r.kernel.org;
> prabhakar.mahadev-lad.rj@...renesas.com; jic23@...nel.org
> Subject: Re: [PATCH -next] iio: adc: add missing
> clk_disable_unprepare() in rzg2l_adc_pm_runtime_resume()
> 
> On Thu, Aug 19, 2021 at 4:19 PM Yang Yingliang
> <yangyingliang@...wei.com> wrote:
> >
> > Add clk_disable_unprepare() on error path in
> rzg2l_adc_pm_runtime_resume().
> 
> ...
> 
> >         ret = clk_prepare_enable(adc->adclk);
> > -       if (ret)
> > +       if (ret) {
> > +               clk_disable_unprepare(adc->pclk);
> >                 return ret;
> > +       }
> 
> Huh?!
> 

Had the same reaction when looked at this patch. Look at the
clock names :).

- Nuno Sá