linux-kernel - Re: [PATCH] arm64/mm: Drop page-def.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4043e66c-c70b-00f8-4c0f-78b62b21a023@arm.com>
Date:   Fri, 20 Aug 2021 14:22:10 +0530
From:   Anshuman Khandual <anshuman.khandual@....com>
To:     Will Deacon <will@...nel.org>
Cc:     linux-arm-kernel@...ts.infradead.org,
        Catalin Marinas <catalin.marinas@....com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64/mm: Drop page-def.h



On 8/20/21 2:01 PM, Will Deacon wrote:
> On Fri, Aug 20, 2021 at 12:05:31PM +0530, Anshuman Khandual wrote:
>> PAGE_SHIFT (PAGE_SIZE and PAGE_MASK) which is derived from ARM64_PAGE_SHIFT
>> should be moved into pgtable-hwdef.h instead, and subsequently page-def.h
>> can be just dropped off completely.
> 
> According to who?
> 
> Every other architecture defines PAGE_SHIFT in page.h, so if you're moving
> things around then that sounds like a better choice.

Sure, will change. That is why I had asked the question :)

> 
> Will
>