linux-kernel - Re: [PATCH] sched: Fix Core-wide rq->lock for uninitialized CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210820100238.GA2314@worktop.programming.kicks-ass.net>
Date:   Fri, 20 Aug 2021 12:02:38 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Josh Don <joshdon@...gle.com>
Cc:     Eugene Syromiatnikov <esyr@...hat.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        "Hyser,Chris" <chris.hyser@...cle.com>,
        Ingo Molnar <mingo@...nel.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Valentin Schneider <valentin.schneider@....com>,
        Mel Gorman <mgorman@...e.de>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Christian Brauner <christian.brauner@...ntu.com>, ldv@...ace.io
Subject: Re: [PATCH] sched: Fix Core-wide rq->lock for uninitialized CPUs

On Thu, Aug 19, 2021 at 05:18:22PM -0700, Josh Don wrote:
> Hi Peter,
> 
> On Thu, Aug 19, 2021 at 4:09 AM Peter Zijlstra <peterz@...radead.org> wrote:
> >
> > -       /* shared state */
> > +       /* shared state -- careful with sched_core_cpu_deactivate() */
> 
> Could also throw these fields into a wrapping struct. Either way seems fine.
> 
> Reviewed-by: Josh Don <joshdon@...gle.com>

Yes, I considered that, but didn't want the churn at this time.