linux-kernel - Re: [PATCH v4 1/1] asus-wmi: Add support for custom fan curves

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <U8X4YQ.79I8GZJ1LDW02@ljones.dev>
Date:   Fri, 20 Aug 2021 23:00:30 +1200
From:   Luke Jones <luke@...nes.dev>
To:     Bastien Nocera <hadess@...ess.net>
Cc:     linux-kernel@...r.kernel.org, hdegoede@...hat.com,
        platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v4 1/1] asus-wmi: Add support for custom fan curves



On Fri, Aug 20 2021 at 12:51:08 +0200, Bastien Nocera 
<hadess@...ess.net> wrote:
> On Fri, 2021-08-20 at 12:43 +0200, Bastien Nocera wrote:
>>  On Fri, 2021-08-20 at 22:33 +1200, Luke Jones wrote:
>>  > > Am I going to get bug reports from Asus users that will complain
>>  > > that
>>  > > power-profiles-daemon doesn't work correctly, where I will have
>>  > > to
>>  > > wearily ask if they're using an Asus Rog laptop?
>>  >
>>  > No. Definitely not. The changes to fan curves per-profile need to
>>  > be
>>  > explicitly enabled and set. So a new user will be unaware that 
>> this
>>  > control exists (until they look for it) and their laptop will
>>  > behave
>>  > exactly as default.
>> 
>>  "The user will need to change the fan curves manually so will
>>  definitely remember to mention it in bug reports" is a very 
>> different
>>  thing to "the user can't change the fan curves to be nonsensical and
>>  mean opposite things".
>> 
>>  I can assure you that I will eventually get bug reports from "power
>>  users" who break their setup and wonder why things don't work
>>  properly,
>>  without ever mentioning the changes they made changes to the fan
>>  curves, or anything else they might have changed.
> 
> A way to taint the settings that power-profiles-daemon could catch
> would be fine by me. I absolutely don't want to have to support
> somebody's tweaks until they undo them.

Definitely understood. Do you have something in mind?

>