linux-kernel - Re: [PATCH 13/13] mtd: spinand: Add support for Winbond W35N01JW SPI NAND flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210820140210.47d348dc@xps13>
Date:   Fri, 20 Aug 2021 14:02:10 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Apurva Nandan <a-nandan@...com>
Cc:     Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Mark Brown <broonie@...nel.org>,
        Patrice Chotard <patrice.chotard@...s.st.com>,
        Boris Brezillon <boris.brezillon@...labora.com>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <linux-spi@...r.kernel.org>, Pratyush Yadav <p.yadav@...com>
Subject: Re: [PATCH 13/13] mtd: spinand: Add support for Winbond W35N01JW
 SPI NAND flash

Hi Apurva,

Apurva Nandan <a-nandan@...com> wrote on Fri, 20 Aug 2021 17:21:33
+0530:

> Hi Miquèl,
> 
> On 07/08/21 12:44 am, Miquel Raynal wrote:
> > Hi Apurva,
> > 
> > Apurva Nandan <a-nandan@...com> wrote on Tue, 13 Jul 2021 13:05:38
> > +0000:
> >   
> >> Winbond W35N01JW is SPI NAND flash supporting Octal DTR SPI protocol.  
> > 
> >                       a
> >   
> >> Add op_vairants for W35N01JW, which include the Octal DTR read/write  
> > 
> > variants
> >   
> >> page ops as well. Add W35N01JW's oob layout functions for the  
> > 
> >                                     OOB
> >   
> 
> Okay, will correct these.
> 
> >> mtd_ooblayout_ops. Add all op adjustments required for Octal DTR SPI
> >> mode using the adjust_op(). Finally, add an entry for W35N01JW in
> >> spinand_info table.
> >>
> >> Datasheet: https://www.winbond.com/export/sites/winbond/datasheet/W35N01JW_Datasheet_Brief.pdf
> >>  
> > 
> > Maybe we can split this into two parts:
> > 1/ support the chip
> > 2/ add 8-D support
> >   
> 
> I can split the patch into:
> 1/ Add implementation of manufacturer_ops: adjust_op() to handle variations of ops in 8D-8D-8D mode
> 2/ Add support/entry for Winbond W35N01JW SPI NAND flash chip
> 
> As 8-D support has already been added in a previous patch.

I also don't want the renaming to happen in the patch adding more
logic.

Thanks,
Miquèl