linux-kernel - Re: [PATCH v4] HID: logitech-hidpp: battery: provide CAPACITY property for newer devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 20 Aug 2021 14:33:13 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Hamza Mahfooz <someguy@...ective-light.com>
cc:     linux-kernel@...r.kernel.org,
        Filipe Laíns <lains@...eup.net>,
        Bastien Nocera <hadess@...ess.net>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org
Subject: Re: [PATCH v4] HID: logitech-hidpp: battery: provide CAPACITY property
 for newer devices

On Mon, 2 Aug 2021, Hamza Mahfooz wrote:

> For devices that only support the BATTERY_VOLTAGE (0x1001) feature, UPower
> requires the additional information provided by this patch, to set them up.
> 
> Signed-off-by: Hamza Mahfooz <someguy@...ective-light.com>
> ---
> 
> v2: use ARRAY_SIZE() and set voltages[]'s size to 100
> 
> v3: add a check to ensure that exactly 100 elements are in voltages[]
> 
> v4: add a note regarding the voltage curve and introduce a bounds check on
>     the reported voltage

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs