[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ae4c58fe-0af5-3f1d-cc16-27b78772cbb5@microchip.com>
Date: Fri, 20 Aug 2021 13:28:48 +0000
From: <Tudor.Ambarus@...rochip.com>
To: <krzysztof.kozlowski@...onical.com>, <p.yadav@...com>
CC: <miquel.raynal@...tlin.com>, <richard@....at>, <vigneshr@...com>,
<robh+dt@...nel.org>, <paul.walmsley@...ive.com>,
<palmer@...belt.com>, <aou@...s.berkeley.edu>,
<atish.patra@....com>, <sagar.kadam@...ive.com>,
<linux-mtd@...ts.infradead.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH 1/5] dt-bindings: mtd: jedec,spi-nor: document
issi,is25wp256
On 8/19/21 8:36 PM, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 19/08/2021 19:28, Pratyush Yadav wrote:
>> + Tudor (you should be listed as a maintainer for this file IMO)
>>
>> On 19/08/21 06:59PM, Krzysztof Kozlowski wrote:
>>> Document bindings for the issi,is25wp256 SPI NOR flash.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
>>> ---
>>> Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>>> index ed590d7c6e37..0db64ac7dc33 100644
>>> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>>> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>>> @@ -33,6 +33,7 @@ properties:
>>> - items:
>>> - enum:
>>> - issi,is25lp016d
>>> + - issi,is25wp256
>>
>> I don't think we want to add any new flash specific compatibles. Why is
>> "jedec,spi-nor" not enough for you?
>
> It's fine for me. I had impression that specific compatibles are still
> preferred and one of boards is using this one. The other way is to
> remove this compatible from the board DTS.
>
Pratyush is right, we prefer to bind just to the generic "jedec,spi-nor"
compatible whenever possible.
Cheers,
ta
Powered by blists - more mailing lists