linux-kernel - Re: [PATCH v3 1/2] selftests: vm: add KSM merging time test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+CK2bCfqGsZKr5Fh3pRC6NcyJExxjrg7C6NxQWvZbVa_PeK=Q@mail.gmail.com>
Date:   Fri, 20 Aug 2021 13:19:23 -0400
From:   Pavel Tatashin <pasha.tatashin@...een.com>
To:     Tyler Hicks <tyhicks@...ux.microsoft.com>
Cc:     Zhansaya Bagdauletkyzy <zhansayabagdaulet@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-mm <linux-mm@...ck.org>, linux-kselftest@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] selftests: vm: add KSM merging time test

On Thu, Aug 19, 2021 at 12:29 PM Tyler Hicks
<tyhicks@...ux.microsoft.com> wrote:
>
> On 2021-08-19 21:33:41, Zhansaya Bagdauletkyzy wrote:
> > Add ksm_merge_time() function to determine speed and time needed for
> > merging. The total spent time is shown in seconds while speed is
> > in MiB/s. User must specify the size of duplicated memory area (in MiB)
> > before running the test.
> >
> > The test is run as follows: ./ksm_tests -P -s 100
> > The output:
> >       Total size:    100 MiB
> >       Total time:    0.201106786 s
> >       Average speed:  497.248 MiB/s
> >
> > Signed-off-by: Zhansaya Bagdauletkyzy <zhansayabagdaulet@...il.com>
> > ---
> > v2 -> v3:
> >  - no changes
>
> There were no changes to this patch since v2 so my previous review still
> stands:
>
>  Reviewed-by: Tyler Hicks <tyhicks@...ux.microsoft.com>

Thank you for addressing my comments in v2.

Reviewed-by: Pavel Tatashin <pasha.tatashin@...een.com>