linux-kernel - RE: [RFC net-next 1/7] ptp: Add interface for acquiring DPLL state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR11MB49518ED9AAF8B543FD8324B9EAC19@PH0PR11MB4951.namprd11.prod.outlook.com>
Date:   Fri, 20 Aug 2021 18:30:02 +0000
From:   "Machnikowski, Maciej" <maciej.machnikowski@...el.com>
To:     Richard Cochran <richardcochran@...il.com>
CC:     "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "shuah@...nel.org" <shuah@...nel.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "nikolay@...dia.com" <nikolay@...dia.com>,
        "cong.wang@...edance.com" <cong.wang@...edance.com>,
        "colin.king@...onical.com" <colin.king@...onical.com>,
        "gustavoars@...nel.org" <gustavoars@...nel.org>,
        "Bross, Kevin" <kevin.bross@...el.com>,
        "Stanton, Kevin B" <kevin.b.stanton@...el.com>,
        Ahmad Byagowi <abyagowi@...com>
Subject: RE: [RFC net-next 1/7] ptp: Add interface for acquiring DPLL state



> -----Original Message-----
> From: Richard Cochran <richardcochran@...il.com>
> Sent: Friday, August 20, 2021 5:56 PM
> To: Machnikowski, Maciej <maciej.machnikowski@...el.com>
> Cc: Kubalewski, Arkadiusz <arkadiusz.kubalewski@...el.com>; linux-
> kernel@...r.kernel.org; intel-wired-lan@...ts.osuosl.org;
> netdev@...r.kernel.org; linux-kselftest@...r.kernel.org; Brandeburg,
> Jesse <jesse.brandeburg@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; davem@...emloft.net; kuba@...nel.org;
> shuah@...nel.org; arnd@...db.de; nikolay@...dia.com;
> cong.wang@...edance.com; colin.king@...onical.com;
> gustavoars@...nel.org; Bross, Kevin <kevin.bross@...el.com>; Stanton,
> Kevin B <kevin.b.stanton@...el.com>; Ahmad Byagowi <abyagowi@...com>
> Subject: Re: [RFC net-next 1/7] ptp: Add interface for acquiring DPLL state
> 
> 1. Control bits according to IEEE 802.3 Section 40.5.2 as Ethtool or RTNL.
> 
> 2. User space Ethernet Synchronization Messaging Channel (ESMC)
>    service according to IEEE 802.3ay
> 
> The PHY should be automatically controlled by #1.
> 
> As I said before, none of this belongs in the PHC subsystem.
> 
> Thanks,
> Richard

Sure!

I did a talk at netDev 0x15 covering SyncE - you can refer to the slides for more detailed info, and hopefully the recording will be available soon as well:
https://netdevconf.info/0x15/session.html?Introduction-to-time-synchronization-over-Ethernet

At its core - SyncE requires 2 parts (see slide 22/23)
 - SyncE capable PHY
 - the external DPLL

The SyncE capable PHY is a PHY that can recover the physical clock, at which the data symbols are transferred, (usually) divide it and output it to the external PLL. It can also redirect the recovered and divided clock to more than one pin.
Since the 40.5.2 is not applicable to higher-speed ethernet which don't use auto-negotiation, but rather the link training sequence where the RX side always syncs its clock to the TX side.

The external DPLL tunes the frequency generated by a crystal to the frequency recovered by the PHY, and drives the outputs.

On the other end - the SyncE PHY uses the clock generated by the DPLL to transmit the data to the next element.

So to be able to control SyncE we need 2 interfaces:
- Interface to enable the recovered clock output at the given pin
- interface to monitor the DPLL to see if the clock that we got is valid, or not.

If it comes to ESMC (G.8264) messages, SyncE itself can run in 2 modes (slides 29/30 will give you more details):
- QL-Disabled - with no ESMC messages - it base on the local information from the PLL to make all decisions
- QL-Enabled - that adds ESMC and quality message transfer between the nodes.

Additionally, the SyncE DPLL can be synchronized to the external sources, like a 1PPS or a 10M signal from the GNSS.

That's why the RFC proposes 2 interfaces:
- one for enabling redirected clock on a selected pin of the PHY
- one for the physical frequency lock of the DPLL

The connection with the PTP subsystem is that in most use cases I heard about SyncE is used as a physical frequency syntonization for PTP clocks.
Hence adding a DPLL monitoring there would solve 2 issues at the same time - monitoring of a GNSS-syntonized PTP clock and the SyncE syntonized one and would make a single point to monitor by the upper layer applications.

Let me know if that makes more sense now. We could add a separate SyncE and separate PTP DPLL monitoring interfaces, but in most cases they will point to the same device.

Regards
Maciek