linux-kernel - Re: [PATCH] staging: r8188eu: remove forward declaration of Efuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b0819fe2-e7cf-b6bc-5930-a31e10da811d@gmail.com>
Date:   Sat, 21 Aug 2021 10:30:27 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        gregkh@...uxfoundation.org, Phillip Potter <phil@...lpotter.co.uk>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        martin@...ser.cx, Larry.Finger@...inger.net
Subject: Re: [PATCH] staging: r8188eu: remove forward declaration of
 Efuse_Read1ByteFromFakeContent



On 8/21/21 5:17 AM, Fabio M. De Francesco wrote:
> On Saturday, August 21, 2021 2:05:08 AM CEST Phillip Potter wrote:
>> Remove forward declaration of Efuse_Read1ByteFromFakeContent function
>> from core/rtw_efuse.c, as the function is defined in full directly
>> after this and therefore this forward declaration is redundant.
>>
>> Signed-off-by: Phillip Potter <phil@...lpotter.co.uk>
>> ---
>>   drivers/staging/r8188eu/core/rtw_efuse.c | 6 ------
>>   1 file changed, 6 deletions(-)
> 
> Philip,
> 
> It's pretty clear that this function has only a translation unit visibility.
> Why don't you make it clear by defining it with storage class "static"?
> 
> Thanks,
> 
> Fabio
> 
> 

Hi Phillip,

I agree with Fabio, making the function static avoids the 
[-Wmissing-prototypes] warning and makes it clear that it is only used 
in this file.

Thanks,

Michael