linux-kernel - Re: [PATCH v2] staging: r8188eu: change declaration of Efuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f151ef3c-d625-a937-2096-afae4fee20f1@gmail.com>
Date:   Sat, 21 Aug 2021 13:02:53 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     Phillip Potter <phil@...lpotter.co.uk>, gregkh@...uxfoundation.org
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        martin@...ser.cx, Larry.Finger@...inger.net,
        fmdefrancesco@...il.com
Subject: Re: [PATCH v2] staging: r8188eu: change declaration of
 Efuse_Read1ByteFromFakeContent

On 8/21/21 12:56 PM, Phillip Potter wrote:
> Remove forward declaration of Efuse_Read1ByteFromFakeContent function
> from core/rtw_efuse.c, as the function is defined in full directly
> after this and therefore this forward declaration is redundant.
> 
> In addition, convert the storage class of the function to static, as the
> function is only used with rtw_efuse.c, and tidy up the signature
> alignment.
> 
> Signed-off-by: Phillip Potter <phil@...lpotter.co.uk>
> ---
> 
> V1: Removed forward declaration.
> V2: Takes account of feedback from Michael Straube and Fabio M. De
>      Francesco to make storage class of the function static.
> 
> ---
>   drivers/staging/r8188eu/core/rtw_efuse.c | 14 +++-----------
>   1 file changed, 3 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_efuse.c b/drivers/staging/r8188eu/core/rtw_efuse.c
> index decccf7622f0..c1c70648f5bc 100644
> --- a/drivers/staging/r8188eu/core/rtw_efuse.c
> +++ b/drivers/staging/r8188eu/core/rtw_efuse.c
> @@ -29,17 +29,9 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0};
>   #define REG_EFUSE_CTRL		0x0030
>   #define EFUSE_CTRL			REG_EFUSE_CTRL		/*  E-Fuse Control. */
>   /*  */
> -
> -bool
> -Efuse_Read1ByteFromFakeContent(
> -			struct adapter *pAdapter,
> -			u16 Offset,
> -		u8 *Value);
> -bool
> -Efuse_Read1ByteFromFakeContent(
> -			struct adapter *pAdapter,
> -			u16 Offset,
> -		u8 *Value)
> +static bool Efuse_Read1ByteFromFakeContent(struct adapter *pAdapter,
> +					   u16 Offset,
> +					   u8 *Value)
>   {
>   	if (Offset >= EFUSE_MAX_HW_SIZE)
>   		return false;
> 

Looks good to me.

Acked-by: Michael Straube<straube.linux@...il.com>


Thanks,

Michael