linux-kernel - [PATCH linux-next] video: fbdev: mb862xx: drop unneeded assignment in the mb86290fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 20 Aug 2021 19:18:33 -0700
From:   CGEL <cgel.zte@...il.com>
To:     dri-devel@...ts.freedesktop.org
Cc:     linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Luo penghao <luo.penghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: [PATCH linux-next] video: fbdev: mb862xx: drop unneeded assignment in the mb86290fb_imageblit8()

From: Luo penghao <luo.penghao@....com.cn>

The first assignment is not used.In order to keep the
code style consistency of the whole file,the first
‘ptr’ assignment should be deleted.

The clang_analyzer complains as follows:

drivers/video/fbdev/mb862xx/mb862xxfb_accel.c:135:9: warning:
Although the value storedto 'ptr' is used in the enclosing expression,
the value is never actually read from 'ptr'.

Reported-by: Zeal Robot <zealci@....com.cn>
Signed-off-by: Luo penghao <luo.penghao@....com.cn>
---
 drivers/video/fbdev/mb862xx/mb862xxfb_accel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c b/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
index d40b806..61aed7f 100644
--- a/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
+++ b/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
@@ -132,7 +132,7 @@ static void mb86290fb_imageblit8(u32 *cmd, u16 step, u16 dx, u16 dy,
 	cmd[2] = (height << 16) | width;
 
 	i = 0;
-	line = ptr = image->data;
+	line = image->data;
 	bytes = image->width;
 
 	while (i < height) {
-- 
2.15.2